follow up #15951 #17478
Closed
follow up #15951 #17478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
konsumlamm
suggested changes
Mar 23, 2021
| @@ -113,3 +113,94 @@ func strip*(a: var string, leading = true, trailing = true, chars: set[char] = w | |||
| assert c == "X" | |||
|
|
|||
| setSlice(a, stripSlice(a, leading, trailing, chars)) | |||
|
|
|||
| proc isLowerAscii*(c: char): bool {.inline.} = | |||
| ## Checks whether or not `c` is a lower case character. | |||
There was a problem hiding this comment.
Suggested change
| ## Checks whether or not `c` is a lower case character. | |
| ## Checks whether or not `c` is a lowercase ASCII character. |
| c in {'a'..'z'} | ||
|
|
||
| proc isUpperAscii*(c: char): bool {.inline.} = | ||
| ## Checks whether or not `c` is an upper case character. |
There was a problem hiding this comment.
Suggested change
| ## Checks whether or not `c` is an upper case character. | |
| ## Checks whether or not `c` is an uppercase ASCII character. |
|
The new |
|
will review tomorrow |
dom96
reviewed
Mar 24, 2021
| if isInit and n > n0: | ||
| zeroMem(result[n0].addr, n - n0) | ||
|
|
||
| proc forceCopy*(result: var string, a: string) = |
There was a problem hiding this comment.
can't https://nim-lang.org/docs/system.html#deepCopy%2CT%2CT be used?
ghost
reviewed
Mar 25, 2021
|
|
||
| proc forceCopy*(result: var string, a: string) = | ||
| ## Always forces a copy no matter whether `a` is shallow. | ||
| # the naitve `result = a` would not work if `a` is shallow |
There was a problem hiding this comment.
Suggested change
| # the naitve `result = a` would not work if `a` is shallow | |
| # the naive `result = a` would not work if `a` is shallow |
|
Are these useful "basics" though? I never used strutils2.nim. |
|
Sorry, rejected. Additions to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #15951 and #16280
remove
compiler/strutils2and move the procs tostd/strbasics.